This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
Add skiplist to http.checker.config - #6689
Merged
Merged
Conversation
Merged
Contributor
|
Good catch! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this commit is to avoid having Travis hit whitelisted rulesets in
test/fetch.shwhich caused some unexpected behaviour in #6684 (and possibly other places?)I suppose one should really ask oneself why the skiplist is not already in there, and what the expected behaviour actually should be, but when I put in the config last year, I think I just omitted it by mistake. At least, I can't really come with any reason for doing it on purpose.
For testing, I added the contents of this PR to #6684 after which all tests were green.